Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore linter warnings for g115 rule #768

Merged
merged 1 commit into from
Aug 21, 2024
Merged

ignore linter warnings for g115 rule #768

merged 1 commit into from
Aug 21, 2024

Conversation

iprotsiuk
Copy link
Contributor

Description

ignore linter warnings for G115 securego/gosec#1185

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

@iprotsiuk @acosta11
ignore linter warnings for g115 rule
f1106d1 
Signed-off-by: Andrew Costa <andrew.costa@broadcom.com>
@iprotsiuk iprotsiuk requested a review from a team as a code owner August 21, 2024 21:16
acosta11
acosta11 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@acosta11 acosta11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkocher mkocher merged commit fa038df into cloudfoundry:main Aug 21, 2024
6 checks passed
@mkocher mkocher deleted the ignore-linter-g115 branch August 21, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acosta11 acosta11 acosta11 approved these changes

@mkocher mkocher mkocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iprotsiuk @mkocher @acosta11